Le 24/03/2020 à 13:22, Chenqun (kuhn) a écrit : >> -----Original Message----- >> From: Laurent Vivier [mailto:laur...@vivier.eu] >> Sent: Tuesday, March 24, 2020 6:59 PM >> To: Chenqun (kuhn) <kuhn.chen...@huawei.com>; qemu-devel@nongnu.org; >> qemu-triv...@nongnu.org >> Cc: Zhanghailiang <zhang.zhanghaili...@huawei.com>; phi...@redhat.com; >> Euler Robot <euler.ro...@huawei.com>; Igor Mitsyanko >> <i.mitsya...@gmail.com>; Peter Maydell <peter.mayd...@linaro.org> >> Subject: Re: [PATCH v4 3/3] timer/exynos4210_mct: Remove redundant >> statement in exynos4210_mct_write() >> >> Le 24/03/2020 à 09:22, Chen Qun a écrit : >>> Clang static code analyzer show warning: >>> hw/timer/exynos4210_mct.c:1370:9: warning: Value stored to 'index' is never >> read >>> index = GET_L_TIMER_CNT_REG_IDX(offset, lt_i); >>> ^ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ >>> hw/timer/exynos4210_mct.c:1399:9: warning: Value stored to 'index' is never >> read >>> index = GET_L_TIMER_CNT_REG_IDX(offset, lt_i); >>> ^ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ >>> hw/timer/exynos4210_mct.c:1441:9: warning: Value stored to 'index' is never >> read >>> index = GET_L_TIMER_CNT_REG_IDX(offset, lt_i); >>> ^ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ >> >> It would be interesting to understand why we need the index for these >> registers >> in exynos4210_mct_read() and not in exynos4210_mct_write(). >> > I think the index can also be used in exynos4210_mct_write(), but the > original author used a more obvious reg name instead of it. > > The obvious reg name: > case L0_TCNTB: case L1_TCNTB: > reg name is : L_REG_CNT_TCNTB > > case L0_ICNTB: case L1_ICNTB: > reg name is : L_REG_CNT_ICNTB > > case L0_FRCNTB: case L1_FRCNTB: > reg name is : L_REG_CNT_FRCCNTB >
Yes, you're right. Computed index gives the value used with s->l_timer[lt_i].reg.cnt[]. Reviewed-by: Laurent Vivier <laur...@vivier.eu> Thanks, Laurent
