Le 24/03/2020 à 09:22, Chen Qun a écrit : > Clang static code analyzer show warning: > hw/display/blizzard.c:940:9: warning: Value stored to 'data' is never read > data >>= 5; > ^ ~ > Reported-by: Euler Robot <euler.ro...@huawei.com> > Signed-off-by: Chen Qun <kuhn.chen...@huawei.com> > --- > Cc: Andrzej Zaborowski <balr...@gmail.com> > Cc: Peter Maydell <peter.mayd...@linaro.org> > --- > hw/display/blizzard.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/hw/display/blizzard.c b/hw/display/blizzard.c > index 359e399c2a..62517bdf75 100644 > --- a/hw/display/blizzard.c > +++ b/hw/display/blizzard.c > @@ -937,7 +937,6 @@ static void blizzard_draw_line16_32(uint32_t *dest, > g = (data & 0x3f) << 2; > data >>= 6; > r = (data & 0x1f) << 3; > - data >>= 5; > *dest++ = rgb_to_pixel32(r, g, b); > } > } >
Perhaps it would be clearer to use extract32() to compute r, g and b? Thanks, Laurent
