On Tue, Oct 22, 2019 at 06:51:39PM +0200, Christophe de Dinechin wrote:
>
> Stefan Hajnoczi writes:
> [...]
> > +static uint16_t qvirtio_readw(QVirtioDevice *d, QTestState *qts, uint64_t
> > addr)
> > +{
> > + uint16_t val = qtest_readw(qts, addr);
> > +
> > + if (d->features & (1ull << VIRTIO_F_VERSION_1) &&
> > qtest_big_endian(qts)) {
>
> For my education, I was wondering why tests use the (1ull << FEATURE)
> notation and not an equivalent of virtio_has_feature()? Is this
> intentional, or just legacy?It's historical, libqos never defined an equivalent helper function. Stefan
signature.asc
Description: PGP signature
