Re: [PATCH v3 09/16] libqos: access VIRTIO 1.0 vring in little-endian

[Christophe de Dinechin]

Stefan Hajnoczi writes:
[...]
> +static uint16_t qvirtio_readw(QVirtioDevice *d, QTestState *qts, uint64_t 
> addr)
> +{
> +    uint16_t val = qtest_readw(qts, addr);
> +
> +    if (d->features & (1ull << VIRTIO_F_VERSION_1) && qtest_big_endian(qts)) 
> {

For my education, I was wondering why tests use the (1ull << FEATURE)
notation and not an equivalent of virtio_has_feature()? Is this
intentional, or just legacy?


--
Cheers,
Christophe de Dinechin (IRC c3d)