Patchew URL: https://patchew.org/QEMU/[email protected]/
Hi, This series seems to have some coding style problems. See output below for more information: Subject: [Qemu-devel] [PATCH v19 00/21] Add RX archtecture support Type: series Message-id: [email protected] === TEST SCRIPT BEGIN === #!/bin/bash git rev-parse base > /dev/null || exit 0 git config --local diff.renamelimit 0 git config --local diff.renames True git config --local diff.algorithm histogram ./scripts/checkpatch.pl --mailback base.. === TEST SCRIPT END === From https://github.com/patchew-project/qemu t [tag update] patchew/[email protected] -> patchew/[email protected] Switched to a new branch 'test' 58a573e6f3 BootLinuxConsoleTest: Test the RX-Virt machine 918428885e MAINTAINERS: Add RX 89799721e3 Add rx-softmmu f7f4625475 hw/registerfields.h: Add 8bit and 16bit register macros 6daadfe34a qemu/bitops.h: Add extract8 and extract16 0487222cc3 hw/rx: Restrict the RX62N microcontroller to the RX62N CPU core 8a072d9cbd hw/rx: Honor -accel qtest 7436a614ae hw/rx: RX Target hardware definition 3fe9feaaa1 hw/char: RX62N serial communication interface (SCI) e5fa50acc3 hw/timer: RX62N internal timer modules 4d169ff249 hw/intc: RX62N interrupt controller (ICUa) 022078a0f7 target/rx: Dump bytes for each insn during disassembly 45adab31f7 target/rx: Collect all bytes during disassembly 9aff31efc4 target/rx: Emit all disassembly in one prt() 68d849ace3 target/rx: Use prt_ldmi for XCHG_mr disassembly 7e6d45f225 target/rx: Replace operand with prt_ldmi in disassembler 3967775d29 target/rx: Disassemble rx_index_addr into a string b679fbb1df target/rx: RX disassembler 2573ca0cc1 target/rx: CPU definition 64cf4c358f target/rx: TCG helper 694178d9a4 target/rx: TCG translation === OUTPUT BEGIN === 1/21 Checking commit 694178d9a413 (target/rx: TCG translation) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #20: new file mode 100644 total: 0 errors, 1 warnings, 3065 lines checked Patch 1/21 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 2/21 Checking commit 64cf4c358ff3 (target/rx: TCG helper) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #18: new file mode 100644 total: 0 errors, 1 warnings, 649 lines checked Patch 2/21 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 3/21 Checking commit 2573ca0cc1e9 (target/rx: CPU definition) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #18: new file mode 100644 total: 0 errors, 1 warnings, 645 lines checked Patch 3/21 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 4/21 Checking commit b679fbb1df50 (target/rx: RX disassembler) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #38: new file mode 100644 total: 0 errors, 1 warnings, 1497 lines checked Patch 4/21 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 5/21 Checking commit 3967775d2986 (target/rx: Disassemble rx_index_addr into a string) 6/21 Checking commit 7e6d45f225f8 (target/rx: Replace operand with prt_ldmi in disassembler) 7/21 Checking commit 68d849ace328 (target/rx: Use prt_ldmi for XCHG_mr disassembly) 8/21 Checking commit 9aff31efc4bc (target/rx: Emit all disassembly in one prt()) 9/21 Checking commit 45adab31f7e4 (target/rx: Collect all bytes during disassembly) 10/21 Checking commit 022078a0f706 (target/rx: Dump bytes for each insn during disassembly) 11/21 Checking commit 4d169ff2494a (hw/intc: RX62N interrupt controller (ICUa)) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #40: new file mode 100644 total: 0 errors, 1 warnings, 442 lines checked Patch 11/21 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 12/21 Checking commit e5fa50acc396 (hw/timer: RX62N internal timer modules) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #50: new file mode 100644 total: 0 errors, 1 warnings, 839 lines checked Patch 12/21 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 13/21 Checking commit 3fe9feaaa1d1 (hw/char: RX62N serial communication interface (SCI)) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #43: new file mode 100644 total: 0 errors, 1 warnings, 398 lines checked Patch 13/21 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 14/21 Checking commit 7436a614ae29 (hw/rx: RX Target hardware definition) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #21: new file mode 100644 total: 0 errors, 1 warnings, 457 lines checked Patch 14/21 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 15/21 Checking commit 8a072d9cbd6d (hw/rx: Honor -accel qtest) 16/21 Checking commit 0487222cc332 (hw/rx: Restrict the RX62N microcontroller to the RX62N CPU core) 17/21 Checking commit 6daadfe34af6 (qemu/bitops.h: Add extract8 and extract16) 18/21 Checking commit f7f4625475a2 (hw/registerfields.h: Add 8bit and 16bit register macros) Use of uninitialized value within @rawlines in concatenation (.) or string at ./scripts/checkpatch.pl line 2467. ERROR: Macros with multiple statements should be enclosed in a do - while loop #27: FILE: include/hw/registerfields.h:25: +#define REG8(reg, addr) \ + enum { A_ ## reg = (addr) }; \ + enum { R_ ## reg = (addr) }; ERROR: Macros with multiple statements should be enclosed in a do - while loop #31: FILE: include/hw/registerfields.h:29: +#define REG16(reg, addr) \ + enum { A_ ## reg = (addr) }; \ + enum { R_ ## reg = (addr) / 2 }; total: 2 errors, 0 warnings, 56 lines checked Patch 18/21 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 19/21 Checking commit 89799721e37a (Add rx-softmmu) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #59: new file mode 100644 total: 0 errors, 1 warnings, 73 lines checked Patch 19/21 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 20/21 Checking commit 918428885e8b (MAINTAINERS: Add RX) 21/21 Checking commit 58a573e6f38e (BootLinuxConsoleTest: Test the RX-Virt machine) === OUTPUT END === Test command exited with code: 1 The full log is available at http://patchew.org/logs/[email protected]/testing.checkpatch/?type=message. --- Email generated automatically by Patchew [https://patchew.org/]. Please send your feedback to [email protected]
