Patchew URL: https://patchew.org/QEMU/[email protected]/
Hi, This series seems to have some coding style problems. See output below for more information: Subject: [Qemu-devel] [PATCH v19 00/21] Add RX archtecture support Type: series Message-id: [email protected] === TEST SCRIPT BEGIN === #!/bin/bash git rev-parse base > /dev/null || exit 0 git config --local diff.renamelimit 0 git config --local diff.renames True git config --local diff.algorithm histogram ./scripts/checkpatch.pl --mailback base.. === TEST SCRIPT END === From https://github.com/patchew-project/qemu t [tag update] patchew/[email protected] -> patchew/[email protected] Switched to a new branch 'test' 317f420e9c BootLinuxConsoleTest: Test the RX-Virt machine 46da289cdf MAINTAINERS: Add RX 2704b207bd Add rx-softmmu c55f2b26ed hw/registerfields.h: Add 8bit and 16bit register macros 895d810896 qemu/bitops.h: Add extract8 and extract16 0c6f47d495 hw/rx: Restrict the RX62N microcontroller to the RX62N CPU core 2bd3bfc71c hw/rx: Honor -accel qtest 95cba7fab4 hw/rx: RX Target hardware definition c3722db947 hw/char: RX62N serial communication interface (SCI) aac94a1b90 hw/timer: RX62N internal timer modules 09c5203a18 hw/intc: RX62N interrupt controller (ICUa) 261816367b target/rx: Dump bytes for each insn during disassembly 65e6b8e8e1 target/rx: Collect all bytes during disassembly b85370af0c target/rx: Emit all disassembly in one prt() 317ee2b1e9 target/rx: Use prt_ldmi for XCHG_mr disassembly ade5bec5af target/rx: Replace operand with prt_ldmi in disassembler 55b02dec27 target/rx: Disassemble rx_index_addr into a string 3313d95145 target/rx: RX disassembler 1574eeedc9 target/rx: CPU definition d55b90871b target/rx: TCG helper 9ac51ee4c5 target/rx: TCG translation === OUTPUT BEGIN === 1/21 Checking commit 9ac51ee4c5a9 (target/rx: TCG translation) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #20: new file mode 100644 total: 0 errors, 1 warnings, 3065 lines checked Patch 1/21 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 2/21 Checking commit d55b90871bb6 (target/rx: TCG helper) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #18: new file mode 100644 total: 0 errors, 1 warnings, 649 lines checked Patch 2/21 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 3/21 Checking commit 1574eeedc93e (target/rx: CPU definition) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #18: new file mode 100644 total: 0 errors, 1 warnings, 645 lines checked Patch 3/21 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 4/21 Checking commit 3313d951455c (target/rx: RX disassembler) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #38: new file mode 100644 total: 0 errors, 1 warnings, 1497 lines checked Patch 4/21 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 5/21 Checking commit 55b02dec27cc (target/rx: Disassemble rx_index_addr into a string) 6/21 Checking commit ade5bec5af34 (target/rx: Replace operand with prt_ldmi in disassembler) 7/21 Checking commit 317ee2b1e9cb (target/rx: Use prt_ldmi for XCHG_mr disassembly) 8/21 Checking commit b85370af0cee (target/rx: Emit all disassembly in one prt()) 9/21 Checking commit 65e6b8e8e1ec (target/rx: Collect all bytes during disassembly) 10/21 Checking commit 261816367bd9 (target/rx: Dump bytes for each insn during disassembly) 11/21 Checking commit 09c5203a18fa (hw/intc: RX62N interrupt controller (ICUa)) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #40: new file mode 100644 total: 0 errors, 1 warnings, 442 lines checked Patch 11/21 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 12/21 Checking commit aac94a1b90a8 (hw/timer: RX62N internal timer modules) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #50: new file mode 100644 total: 0 errors, 1 warnings, 839 lines checked Patch 12/21 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 13/21 Checking commit c3722db9470e (hw/char: RX62N serial communication interface (SCI)) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #43: new file mode 100644 total: 0 errors, 1 warnings, 398 lines checked Patch 13/21 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 14/21 Checking commit 95cba7fab4c5 (hw/rx: RX Target hardware definition) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #21: new file mode 100644 total: 0 errors, 1 warnings, 457 lines checked Patch 14/21 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 15/21 Checking commit 2bd3bfc71cca (hw/rx: Honor -accel qtest) 16/21 Checking commit 0c6f47d495ab (hw/rx: Restrict the RX62N microcontroller to the RX62N CPU core) 17/21 Checking commit 895d8108961c (qemu/bitops.h: Add extract8 and extract16) 18/21 Checking commit c55f2b26ed2d (hw/registerfields.h: Add 8bit and 16bit register macros) Use of uninitialized value within @rawlines in concatenation (.) or string at ./scripts/checkpatch.pl line 2467. ERROR: Macros with multiple statements should be enclosed in a do - while loop #27: FILE: include/hw/registerfields.h:25: +#define REG8(reg, addr) \ + enum { A_ ## reg = (addr) }; \ + enum { R_ ## reg = (addr) }; ERROR: Macros with multiple statements should be enclosed in a do - while loop #31: FILE: include/hw/registerfields.h:29: +#define REG16(reg, addr) \ + enum { A_ ## reg = (addr) }; \ + enum { R_ ## reg = (addr) / 2 }; total: 2 errors, 0 warnings, 56 lines checked Patch 18/21 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 19/21 Checking commit 2704b207bda8 (Add rx-softmmu) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #59: new file mode 100644 total: 0 errors, 1 warnings, 73 lines checked Patch 19/21 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 20/21 Checking commit 46da289cdff8 (MAINTAINERS: Add RX) 21/21 Checking commit 317f420e9c3e (BootLinuxConsoleTest: Test the RX-Virt machine) === OUTPUT END === Test command exited with code: 1 The full log is available at http://patchew.org/logs/[email protected]/testing.checkpatch/?type=message. --- Email generated automatically by Patchew [https://patchew.org/]. Please send your feedback to [email protected]
