On 4/30/19 4:49 AM, Peter Maydell wrote:
>> --- a/target/i386/mem_helper.c
>> +++ b/target/i386/mem_helper.c
>> @@ -191,24 +191,3 @@ void helper_boundl(CPUX86State *env, target_ulong a0,
>> int v)
>> raise_exception_ra(env, EXCP05_BOUND, GETPC());
>> }
>> }
>> -
>> -#if !defined(CONFIG_USER_ONLY)
>> -/* try to fill the TLB and return an exception if error. If retaddr is
>> - * NULL, it means that the function was called in C code (i.e. not
>> - * from generated code or from helper.c)
>> - */
>> -/* XXX: fix it to restore all registers */
>
> Is this XXX comment definitely stale ?
This is a pre-TCG comment, from 61382a500a9 ("full softmmu support"), from
2003. It has only been moved around since. I can only imagine what problem
Fabrice might have been reminding himself.
r~
