On Wed, 3 Apr 2019 at 04:49, Richard Henderson
<richard.hender...@linaro.org> wrote:
>
> We do not support probing, but we do not need it yet either.
>
> Cc: Paolo Bonzini <pbonz...@redhat.com>
> Cc: Eduardo Habkost <ehabk...@redhat.com>
> Signed-off-by: Richard Henderson <richard.hender...@linaro.org>
> + env->retaddr = retaddr;
> + if (handle_mmu_fault(cs, addr, size, access_type, mmu_idx)) {
> + /* FIXME: On error in get_hphys we have already jumpped out. */
"jumped"
> + g_assert(!probe);
> --- a/target/i386/mem_helper.c
> +++ b/target/i386/mem_helper.c
> @@ -191,24 +191,3 @@ void helper_boundl(CPUX86State *env, target_ulong a0,
> int v)
> raise_exception_ra(env, EXCP05_BOUND, GETPC());
> }
> }
> -
> -#if !defined(CONFIG_USER_ONLY)
> -/* try to fill the TLB and return an exception if error. If retaddr is
> - * NULL, it means that the function was called in C code (i.e. not
> - * from generated code or from helper.c)
> - */
> -/* XXX: fix it to restore all registers */
Is this XXX comment definitely stale ?
> -void tlb_fill(CPUState *cs, target_ulong addr, int size,
> - MMUAccessType access_type, int mmu_idx, uintptr_t retaddr)
> -{
> - X86CPU *cpu = X86_CPU(cs);
> - CPUX86State *env = &cpu->env;
> - int ret;
> -
> - env->retaddr = retaddr;
> - ret = x86_cpu_handle_mmu_fault(cs, addr, size, access_type, mmu_idx);
> - if (ret) {
> - raise_exception_err_ra(env, cs->exception_index, env->error_code,
> retaddr);
> - }
> -}
Otherwise
Reviewed-by: Peter Maydell <peter.mayd...@linaro.org>
thanks
-- PMM
