On 1/17/19 3:21 AM, Markus Armbruster wrote: > Eric, there's a QAPI code generation idea at the end. >
>> If that is not there, then the compiler forces the
>> listing of SOCKET_ADDRESS_TYPE__MAX instead due
>> to -Wswitch
>
> I wonder whether generating something like
>
> typedef enum SocketAddressType {
> SOCKET_ADDRESS_TYPE_INET,
> SOCKET_ADDRESS_TYPE_UNIX,
> SOCKET_ADDRESS_TYPE_VSOCK,
> SOCKET_ADDRESS_TYPE_FD,
> } SocketAddressType;
>
> #define SOCKET_ADDRESS_TYPE__MAX (SOCKET_ADDRESS_TYPE_FD + 1)
>
> would be better.
Or even an anon enum instead of a define:
typedef enum SocketAddressType {
SOCKET_ADDRESS_TYPE_INET,
SOCKET_ADDRESS_TYPE_UNIX,
SOCKET_ADDRESS_TYPE_VSOCK,
SOCKET_ADDRESS_TYPE_FD,
} SocketAddressType;
enum {
SOCKET_ADDRESS_TYPE__MAX = SOCKET_ADDRESS_TYPE_FD + 1
};
The idea is interesting; since it is generated code, the change is
fairly easy to make. I don't know how much fall-out we'd get in the
rest of the code base - only one way to find out.
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3226
Virtualization: qemu.org | libvirt.org
signature.asc
Description: OpenPGP digital signature
