On 2019-01-15 15:52, Daniel P. Berrangé wrote: > The 'sioc' variable in qmp_chardev_open_socket was unused since > > commit 3e7d4d20d3a528b1ed10b1dc3d83119bfb0c5f24 > Author: Peter Xu <[email protected]> > Date: Tue Mar 6 13:33:17 2018 +0800 > > chardev: use chardev's gcontext for async connect [...] > -error: > - if (sioc) { > - object_unref(OBJECT(sioc)); > - }
So who is doing the object_unref() now in case of errors? That commit did not take care of it ... so it sounds like we could be leaving references behind in case of errors here? Thomas
