On Wed, Nov 28, 2018 at 02:54:09PM +0000, Daniel P. Berrangé wrote: > On Wed, Nov 28, 2018 at 06:46:37PM +0400, Marc-André Lureau wrote: > > Hi > > > > On Wed, Nov 28, 2018 at 6:33 PM Daniel P. Berrangé <[email protected]> > > wrote: > > > > > > On Wed, Nov 28, 2018 at 06:21:35PM +0400, Marc-André Lureau wrote: > > > > Looking at chardev/spice.c code, I realize compilation was broken for > > > > a while with spice-server < 0.12.3. I propose to bump required version > > > > to 0.12.6, released 3y ago, instead of adding more #ifdef. > > > > > > As mentioned last time this patch was posted[1], any changes in the > > > min required versions should follow our supported build platforms > > > support statement: > > > > Sorry, I totally forgot that. > > > > > > > > https://qemu.weilnetz.de/doc/qemu-doc.html#Supported-build-platforms > > > > > > Preferrably the commit message should list the version in each of the > > > main distros, such as in a0722409bcb980ecdab8330d4c716a73c9fcb489 > > > > > > At a glance it looks like Debian Jessie is likely to be the determining > > > vote with 0.12.5 as its newest version. > > > > https://repology.org/metapackage/spice/versions > > > > Debian Oldstable > > oldstable/main spice 0.12.5 > > > > https://wiki.debian.org/DebianReleases > > > > ~June 6th 2020 (LTS) > > > > But the current stable, Stretch, was released on June 17th 2017. > > > > So we are stuck with spice server 0.12.5 until +2y, June 17th 2019 ? > > Yep, but that means one more dev cycle - 4.0 > > We're free to drop Jessie once QEMU 4.1 opens for development at > end of April / early May.
Ok, lets just put the patch on hold then. I don't think it makes that much sense to jump to 0.12.5 now and 0.12.6 next year. cheers, Gerd
