On Wed, Nov 28, 2018 at 06:21:35PM +0400, Marc-André Lureau wrote: > Looking at chardev/spice.c code, I realize compilation was broken for > a while with spice-server < 0.12.3. I propose to bump required version > to 0.12.6, released 3y ago, instead of adding more #ifdef.
As mentioned last time this patch was posted[1], any changes in the min required versions should follow our supported build platforms support statement: https://qemu.weilnetz.de/doc/qemu-doc.html#Supported-build-platforms Preferrably the commit message should list the version in each of the main distros, such as in a0722409bcb980ecdab8330d4c716a73c9fcb489 At a glance it looks like Debian Jessie is likely to be the determining vote with 0.12.5 as its newest version. Regards, Daniel [1] https://lists.gnu.org/archive/html/qemu-devel/2018-08/msg00905.html -- |: https://berrange.com -o- https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o- https://fstop138.berrange.com :| |: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
