On 06/22/2018 05:24 AM, Thomas Huth wrote: > On 21.06.2018 20:02, Philippe Mathieu-Daudé wrote: >> Signed-off-by: Philippe Mathieu-Daudé <[email protected]> >> --- >> hw/dma/omap_dma.c | 66 ++++++++++++++++++++++++++++++----------------- >> 1 file changed, 42 insertions(+), 24 deletions(-) > [...] >> case 0x78: /* DMA4_GCR */ >> s->gcr = value & 0x00ff00ff; >> - if ((value & 0xff) == 0x00) /* MAX_CHANNEL_FIFO_DEPTH */ >> - fprintf(stderr, "%s: wrong FIFO depth in GCR\n", __func__); >> + if ((value & 0xff) == 0x00) { >> + /* MAX_CHANNEL_FIFO_DEPTH */ >> + qemu_log_mask(LOG_GUEST_ERROR, "%s: wrong FIFO depth in GCR\n", >> + __func__); >> + } >> return; > > Not sure, but doesn't that MAX_CHANNEL_FIFO_DEPTH comment rather belong > to the if-statement than to the print statement? If so, could you please > leave it at the end of the line?
OK ;)
