On 01/18/2018 01:00 PM, Paolo Bonzini wrote:
> On 18/01/2018 16:44, Philippe Mathieu-Daudé wrote:
>>> static void sdhci_common_realize(SDHCIState *s, Error **errp)
>>> {
>>> + sdhci_init_readonly_registers(s, errp);
>>> + if (errp && *errp) {
>> Paolo said this is wrong (as in bad pattern?).
>>
>> I will respin probably using 'bool sdhci_init_readonly_registers()' instead.
>>
>
> Please use the local_err idiom instead.Will do, thanks! Phil.
