On 18/01/2018 16:45, Philippe Mathieu-Daudé wrote:
>> s->version = (SDHC_HCVER_VENDOR << 8) | (s->spec_version - 1);
>>
>> + capab = sdhci_init_capareg(s, errp);
>> + if (errp && *errp) {
> Paolo said this is wrong, I'll resping using UINT64_MAX as error and
> checking "if (capab == UINT64_MAX) { return; }"If all-ones capabilities is valid or can be valid in the future, then perhaps it is better to use local_err, and not use the return value at all if local_err != NULL. Paolo
