On 09/18/2017 07:12 PM, Eric Blake wrote: > On 09/18/2017 11:33 AM, Christian Borntraeger wrote: >> From: Jing Liu <[email protected]> >> >> This patch is the s390 implementation of guest crash information, similar >> to commit d187e08dc4 ("i386/cpu: add crash-information QOM property") and >> the related commits. We will detect several crash reasons, with the >> "disabled wait" being the most important one, since this is used by all >> s390 guests as a "panic like" notification. >> > >> + >> +## >> +# @GuestPanicInformationKVMS390: >> +# >> +# KVM-S390 specific guest panic information (PSW) >> +# >> +# Since: 2.11 >> +## >> +{'struct': 'GuestPanicInformationKVMS390', >> + 'data': { 'psw_mask': 'uint64', >> + 'psw_addr': 'uint64', > > New interfaces should favor '-' over '_'; is there any reason we can't > name these 'psw-mask' and 'pws-addr'?
Can change.
