Sure thing. I implemented it in multiple commits, but there was enough
overlap in those commits that I thought it would require extra
unnecessary work to review. But I also found an issue that needs fixed,
so I need to resubmit anyway.
--
Brandon Carpenter | Software Engineer
Cypherpath, Inc.
400 Columbia Point Drive Ste 101 | Richland, Washington USA
Office: (650) 713-3060
On Tue, Jul 25, 2017 at 1:38 AM, Daniel P. Berrange
<[email protected]> wrote:
On Mon, Jul 24, 2017 at 11:42:17AM -0700, Brandon Carpenter wrote:
Remembering the opcode is sufficient for handling fragmented frames
from
the client, which may be introduced by an intermediary server/proxy.
Respond to pings and ignore pongs rather than close the connection
as
many browsers use ping/pong to test an idle connection. Close
connections according to the RFC, including providing reason code
and
message to aid debugging of unexpected disconnects. Empty payloads
should not cause a disconnect.
Couuld you split this up into multiple patches, each one only fixing
a single problem at a time. It is rather hard to review this for
correctness when everything is changed at once.
Regards,
Daniel
--
|: https://berrange.com -o-
https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org -o-
https://fstop138.berrange.com :|
|: https://entangle-photo.org -o-
https://www.instagram.com/dberrange :|
--
CONFIDENTIALITY NOTICE: This e-mail message, including any attachments, is
for the sole use of the intended recipient(s) and may contain proprietary,
confidential or privileged information or otherwise be protected by law.
Any unauthorized review, use, disclosure or distribution is prohibited. If
you are not the intended recipient, please notify the sender and destroy
all copies and the original message.
