On Mon, Jul 24, 2017 at 11:42:17AM -0700, Brandon Carpenter wrote: > Remembering the opcode is sufficient for handling fragmented frames from > the client, which may be introduced by an intermediary server/proxy. > Respond to pings and ignore pongs rather than close the connection as > many browsers use ping/pong to test an idle connection. Close > connections according to the RFC, including providing reason code and > message to aid debugging of unexpected disconnects. Empty payloads > should not cause a disconnect.
Couuld you split this up into multiple patches, each one only fixing a single problem at a time. It is rather hard to review this for correctness when everything is changed at once. Regards, Daniel -- |: https://berrange.com -o- https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o- https://fstop138.berrange.com :| |: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
