* Daniel P. Berrange ([email protected]) wrote: > On Tue, Mar 14, 2017 at 10:21:43AM +0000, Dr. David Alan Gilbert wrote: > > * Juan Quintela ([email protected]) wrote: > > > Hi > > > > > > This is the 4th version of multifd. Changes: > > > - XBZRLE don't need to be checked for > > > - Documentation and defaults are consistent > > > - split socketArgs > > > - use iovec instead of creating something similar. > > > - We use now the exported size of target page (another HACK removal) > > > - created qio_chanel_{wirtev,readv}_all functions. the _full() name > > > was already taken. > > > What they do is the same that the without _all() function, but if it > > > returns due to blocking it redo the call. > > > - it is checkpatch.pl clean now. > > > > > > Please comment, Juan. > > > > High level things, > > a) I think you probably need to do some bandwidth measurements to show > > that multifd is managing to have some benefit - it would be good > > for the cover letter. > > multi-fd will certainly benefit encrypted migration, since we'll be able > to burn multiple CPUs for AES instead of bottlenecking on one CPU, and > thus able to take greater advantage of networks with > 1-GigE bandwidth.
Yes, that's one I really want to see. It might be odd using lots of fd's just to do that, but probably the easiest way. Dave > Regards, > Daniel > -- > |: http://berrange.com -o- http://www.flickr.com/photos/dberrange/ :| > |: http://libvirt.org -o- http://virt-manager.org :| > |: http://entangle-photo.org -o- http://search.cpan.org/~danberr/ :| -- Dr. David Alan Gilbert / [email protected] / Manchester, UK
