Re: [Qemu-devel] [PATCH 13/16] migration: Create thread infrastructure for multifd recv side

[Paolo Bonzini]

On 13/03/2017 13:44, Juan Quintela wrote:
>          case RAM_SAVE_FLAG_MULTIFD_PAGE:
>              fd_num = qemu_get_be16(f);
> -            if (fd_num != 0) {
> -                /* this is yet an unused variable, changed later */
> -                fd_num = fd_num;
> -            }
> +            multifd_recv_page(host, fd_num);
>              qemu_get_buffer(f, host, TARGET_PAGE_SIZE);
>              break;

I still believe this design is a mistake.

Paolo