----- Original Message ----- > From: "Markus Armbruster" <[email protected]> > To: "Paolo Bonzini" <[email protected]> > Cc: [email protected], [email protected], [email protected] > Sent: Wednesday, August 10, 2016 9:48:24 AM > Subject: Re: [Qemu-devel] [PATCH 2/3] checkpatch: bump most warnings to errors > > Paolo Bonzini <[email protected]> writes: > > >> Paolo Bonzini <[email protected]> writes: > >> > >> > This only leaves a warning-level message for extra-long lines, which > >> > are relatively common and cause patchew to send email that will likely > >> > be ignored. > >> > > >> > Signed-off-by: Paolo Bonzini <[email protected]> > >> > >> Are we ready to give up on illegibly long lines? > > > > We have other levels of code review than checkpatch. 80 chars can be > > illegibly short in some circumstances where 83 or 84 are enough. > > Isn't that addressed neatly in your patch? It has a soft and a hard > limit. Exceeding the hard limit is an error, exceeding the soft limit > is a warning. I rather liked that. If I remember correctly, the only > disagreements were about the value of the soft limit.
Yes, indeed. I can respin the patch then. Paolo
