----- Original Message ----- > From: "Cornelia Huck" <[email protected]> > To: "Paolo Bonzini" <[email protected]> > Cc: [email protected], [email protected], [email protected], > [email protected] > Sent: Wednesday, August 10, 2016 9:46:14 AM > Subject: Re: [Qemu-devel] [PATCH 2/3] checkpatch: bump most warnings to errors > > On Tue, 9 Aug 2016 17:47:43 +0200 > Paolo Bonzini <[email protected]> wrote: > > > This only leaves a warning-level message for extra-long lines, which > > are relatively common and cause patchew to send email that will likely > > be ignored. > > > > Signed-off-by: Paolo Bonzini <[email protected]> > > --- > > scripts/checkpatch.pl | 66 > > +++++++++++++++++++++++++-------------------------- > > 1 file changed, 33 insertions(+), 33 deletions(-) > > > > > # no volatiles please > > my $asm_volatile = > > qr{\b(__asm__|asm)\s+(__volatile__|volatile)\b}; > > if ($line =~ /\bvolatile\b/ && $line !~ /$asm_volatile/) { > > - WARN("Use of volatile is usually wrong: see > > Documentation/volatile-considered-harmful.txt\n" . $herecurr); > > + ERROR("Use of volatile is usually wrong: see > > Documentation/volatile-considered-harmful.txt\n" . $herecurr); > > It's a bit weird to have this refer to a Linux file :)
Right. We should include the explanation in docs/atomics.txt and point to that. Paolo
