Paolo Bonzini writes:
> On 25/02/2016 16:03, Lluís Vilanova wrote:
>> static inline bool trace_event_get_state_dynamic(TraceEvent *ev)
>> {
>> - int id = trace_event_get_id(ev);
>> + TraceEventID id;
>> + assert(ev != NULL);
> Please don't add "!= NULL" asserts. The reason of a crash would be
> pretty obvious from the backtrace.
> In fact a NULL event is especially unlikely given that all events are
> held in an array...
Actually, I was thinking about removing all "assert(ev)" on a separate patch,
since it is very unlikely this will ever happen (and asserts are always compiled
in in QEMU).
Thanks,
Lluis
