On 25/02/2016 16:03, Lluís Vilanova wrote:
> static inline bool trace_event_get_state_dynamic(TraceEvent *ev)
> {
> - int id = trace_event_get_id(ev);
> + TraceEventID id;
> + assert(ev != NULL);
Please don't add "!= NULL" asserts. The reason of a crash would be
pretty obvious from the backtrace.
In fact a NULL event is especially unlikely given that all events are
held in an array...
Paolo
> + assert(trace_event_get_state_static(ev));
> + id = trace_event_get_id(ev);
> return trace_event_get_state_dynamic_by_id(id);
> }
>
