On 04/25/2016 08:46 AM, Stefan Hajnoczi wrote: > This patch series eliminates code duplication in libqos virtio. > include/standard-headers/ contains the Linux virtio header files so we don't > need to define our own version of the structs and constants. >
Is that a good idea? I had thought some of the intentional purpose of duplicating the headers was to test the other versions. > Stefan Hajnoczi (8): > libqos: use virtio_ids.h for device ID definitions > libqos: drop duplicated PCI vendor ID definition > libqos: drop duplicated virtio_config.h definitions > libqos: drop duplicated virtio_ring.h bit definitions > libqos: drop duplicated virtio_vring.h structs > libqos: drop duplicated virtio_blk.h definitions > libqos: drop duplicated virtio_scsi.h definitions > libqos: drop duplicated virtio_pci.h definitions > > tests/libqos/virtio-mmio.c | 5 +-- > tests/libqos/virtio-pci.c | 50 ++++++++++++++------------- > tests/libqos/virtio-pci.h | 17 --------- > tests/libqos/virtio.c | 42 +++++++++++----------- > tests/libqos/virtio.h | 73 ++++----------------------------------- > tests/virtio-blk-test.c | 86 > ++++++++++++++++++++-------------------------- > tests/virtio-net-test.c | 10 +++--- > tests/virtio-scsi-test.c | 53 +++++++++++----------------- > 8 files changed, 123 insertions(+), 213 deletions(-) >
