On Sun, May 08, 2016 at 08:40:36PM +0200, Marc Marí wrote: > On Sun, 8 May 2016 20:22:53 +0200 > Marc Marí <[email protected]> wrote: > > > On Mon, 25 Apr 2016 13:46:08 +0100 > > Stefan Hajnoczi <[email protected]> wrote: > > In standard-headers/linux/virtio_config.h, there is; > > > > #define VIRTIO_F_NOTIFY_ON_EMPTY 24 > > #define VIRTIO_F_ANY_LAYOUT 27 > > > > whereas in tests/libqos.h, there is: > > > > #define QVIRTIO_F_NOTIFY_ON_EMPTY 0x01000000 > > #define QVIRTIO_F_ANY_LAYOUT 0x08000000 > > > > It is necessary to use 2 << VIRTIO_F_NOTIFY_ON_EMPTY to make the > > change properly. > > > > I meant 1 << VIRTIO_F_NOTIFY_ON_EMPTY, obviously. > > And what I say is half corrected in the next patch. I think it would be > nicer to make the changes directly in this patch. > > In any case, this line: > > if (features & VIRTIO_F_ANY_LAYOUT) { > is not corrected in any patch
Thanks for pointing this out, I thought I had caught all instances where (1 << X) and X differ. Will fix in the next revision. Stefan
signature.asc
Description: PGP signature
