Am 21.03.2016 um 18:30 hat Markus Armbruster geschrieben: > Paolo Bonzini <[email protected]> writes: > > > On 21/03/2016 17:15, Markus Armbruster wrote: > >> * Explicitly with x-blockdev-del > >> > >> Fails unless no other reference exists. Where is the legacy_dinfo > >> released? > > > > Can a -drive block device be deleted with x-blockdev-del even?!? > > When I wrote my review, I forgot that I expect x-blockdev-del to accept > only backends created with blockdev-add. With that, my question is > indeed moot. > > However, I've now tested my expectation, and it turned out to be wrong. > I'm inclined to call that a bug.
Yes. > > Shall I add a check to x-blockdev-del that gives an error if the > > BlockBackend has a DriveInfo attached? > > Yes, please. But do double-check with Kevin & Max, who might have > different ideas on blockdev-add/del than I do. I'm pretty sure that I said that failing on -drive/drive_add created BlockBackends was a requirement for x-blockdev-del. Apparently I failed to catch the bug in the review then. So go ahead and let's fix it now. Kevin
