On 21/03/2016 17:15, Markus Armbruster wrote: > * Explicitly with x-blockdev-del > > Fails unless no other reference exists. Where is the legacy_dinfo > released?
Can a -drive block device be deleted with x-blockdev-del even?!? In other words, you said "This looks like DriveInfo now owns a reference to BlockBackend, even though the pointer still goes in the other direction". I say, "I thought this was the idea all along"... Shall I add a check to x-blockdev-del that gives an error if the BlockBackend has a DriveInfo attached? Paolo > * Implicitly via warty automatic deletion > > Your PATCH 01 has the necessary replacement of blk_unref(blk) by > blkdev_del_drive(blk) for some devices (virtio-blk.c, scsi-bus.c, > xen_disk,c, piix.c), butas far as I can see not for others such as > nvme.c.
