On 03/03/2016 15:47, Denis V. Lunev wrote: >> > ok, you are finally right. Your original code is correct and will > work even in these corner case. > > Will it make sense to send a patch which will replace that code > to my one as followup + fix if 'fopen' will fail?
Definitely. While at it, you could move qemu_log_close and qemu_log_flush from the header to the C file. They are in the header only for very historical reasons; exec.c in the past could only invoke a limited amount of external code, but luckily that's not the case anymore. Paolo
