On 03/03/2016 15:08, Denis V. Lunev wrote: > On 03/03/2016 05:04 PM, Paolo Bonzini wrote: >> >> On 03/03/2016 14:53, Denis V. Lunev wrote: >>>> A patch has been posted already, and I'll send a pull request tomorrow. >>> I have not seen it. Can you post a link? >> [PATCH] log: do not log if QEMU is daemonized but without -D >> >> but I found a missing case that your patch handles, so I'll post a v2 >> now. >> >> Paolo > > that is fine :) let's see. Though I think that resulted code is more > readable in my approach.
Yes, I was going for the smallest change. Cleanups can be done on top. Actually, the patch in v1 is fine. My worry after looking at your patch was that I didn't have the dup2(stdout, stderr) case. However, with my change you can never call qemu_log_close if is_daemonized(), because even the monitor command "logfile" cannot set logfilename to NULL. Paolo
