On Tue, 23 Jun 2015 14:42:35 +0200 Michal Privoznik <[email protected]> wrote:
> On 23.06.2015 14:37, Peter Maydell wrote: > > On 23 June 2015 at 13:30, Michal Privoznik <[email protected]> wrote: > >> I'm used to run 'make -j5 all check'. However, this is not possible in > >> qemu because of the missing dependency in the Makefile. If I do that, > >> tests are usually started with build and since not everything is built > >> yet, they often fail too. Moreover, we should run test suite only > >> after every binary we want to test has been built. > >> > >> Signed-off-by: Michal Privoznik <[email protected]> > >> --- > >> Makefile | 1 + > >> 1 file changed, 1 insertion(+) > >> > >> diff --git a/Makefile b/Makefile > >> index e7c5c3a..67eeb87 100644 > >> --- a/Makefile > >> +++ b/Makefile > >> @@ -151,6 +151,7 @@ dummy := $(call unnest-vars,, \ > >> > >> ifneq ($(wildcard config-host.mak),) > >> include $(SRC_PATH)/tests/Makefile > >> +check: all > >> endif > >> ifeq ($(CONFIG_SMARTCARD_NSS),y) > >> include $(SRC_PATH)/libcacard/Makefile > > > > I'm having difficulty understanding the use of conditionals > > in our makefile -- can you explain why inside this ifneq > > rather than outside is the right place for this dependency? > > Well, I guess it could be outside too. My thinking was, that we include > the tests/Makefile - which defines the 'check' target - only > conditionally, therefore the dependency should be defined only sometimes > too. I guess it won't hurt if it was outside too. Maybe it's simpler to add the dependency into tests/Makefile instead? Thomas
