On Fri, 03/27 08:23, Alberto Garcia wrote: > On Fri, Mar 27, 2015 at 09:11:19AM +0800, Fam Zheng wrote: > > > > Hmm... this actually breaks the new test because now BDS are > > > required to have an AioContext attached when they're added to a > > > group, which doesn't happen in qtest: > > > > > > bdrv = bdrv_new(); > > > throttle_group_register_bs(bdrv, "bar"); > > > > > > I'm unsure of how to proceed with this, I don't see a clear way to > > > attach the AioContext here (unless I do bdrv->aio_context = ctx). > > > Suggestions are welcome. > > > > Use bdrv_attach_aio_context? > > That doesn't work in that case, bdrv_attach_aio_context() does nothing > if bdrv->drv is null. > > The test works fine if I set bdrv->aio_context directly as I said > above, but is it ok to do that?
I think it should be OK as a test. Or assert(qtest_enabled()) in throttle_group_register_bs and assign the main loop AioContext, which is basically the same. Fam
