On Thu, 03/26 19:52, Alberto Garcia wrote: > On Thu, Mar 26, 2015 at 07:24:54PM +0200, Alberto Garcia wrote: > > > - The creation/destruction of ThrottleTimers is now handled internally > > when a BlockDriverState is added/removed from a group, since > > there's not much point on keeping them separate. This also hides > > the timer callbacks from the outside, which makes things a bit > > nicer and easier for some of the other changes included in these > > series. > > Hmm... this actually breaks the new test because now BDS are required > to have an AioContext attached when they're added to a group, which > doesn't happen in qtest: > > bdrv = bdrv_new(); > throttle_group_register_bs(bdrv, "bar"); > > I'm unsure of how to proceed with this, I don't see a clear way to > attach the AioContext here (unless I do bdrv->aio_context = ctx). > Suggestions are welcome.
Use bdrv_attach_aio_context? Fam
