On 1 September 2014 14:04, Peter Maydell <peter.mayd...@linaro.org> wrote: > On 1 September 2014 12:55, Ard Biesheuvel <ard.biesheu...@linaro.org> wrote: >> From: Rob Herring <rob.herr...@linaro.org> >> >> Add support for handling PSCI calls in system emulation. Both version >> 0.1 and 0.2 of the PSCI spec are supported. Platforms can enable support >> by setting "psci-method" QOM property on the cpus to SMC or HVC >> emulation and having PSCI binding in their dtb. > >> --- /dev/null >> +++ b/target-arm/psci.c >> @@ -0,0 +1,172 @@ >> +/* >> + * Copyright (C) 2014 - Linaro >> + * Author: Rob Herring <rob.herr...@linaro.org> >> + * >> + * This program is free software; you can redistribute it and/or modify >> + * it under the terms of the GNU General Public License as published by >> + * the Free Software Foundation; either version 2 of the License, or >> + * (at your option) any later version. >> + * >> + * This program is distributed in the hope that it will be useful, >> + * but WITHOUT ANY WARRANTY; without even the implied warranty of >> + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the >> + * GNU General Public License for more details. >> + * >> + * You should have received a copy of the GNU General Public License >> + * along with this program; if not, see <http://www.gnu.org/licenses/>. >> + */ >> +#include <cpu.h> >> +#include <cpu-qom.h> >> +#include <kvm-consts.h> >> +#include <sysemu/sysemu.h> >> +#include <linux/psci.h> > > This isn't going to compile on non-Linux hosts. > (cf discussion at > http://lists.gnu.org/archive/html/qemu-devel/2014-06/msg00473.html) > > I suggest using the QEMU_PSCI_* constants we now have > available in kvm-consts.h and avoiding the plain PSCI_* > ones entirely in non-kvm-specific code. You might need to > add a few new QEMU_PSCI_* where we don't have them yet. >
OK, will do
