> -----Original Message----- > From: Paolo Bonzini [mailto:[email protected]] On Behalf Of Paolo > Bonzini > Sent: Wednesday, May 28, 2014 4:01 PM > To: Gonglei (Arei); [email protected] > Cc: [email protected]; [email protected]; Huangweidong (C); > [email protected]; [email protected]; Luonengjun; [email protected]; > [email protected]; [email protected]; [email protected]; > [email protected]; [email protected]; [email protected]; > [email protected]; [email protected] > Subject: Re: [PATCH 6/8] smbus: Fix unreachable code in smb_transaction() > > Il 28/05/2014 02:59, Gonglei (Arei) ha scritto: > >>> > > - abort(); > >> > > >> > This is intentional defensive programming. A "break" from the switch > >> > would be wrong, hence the "abort" here. > >> > > > But the "break" is unreachable at all case conditions. > > All those cases will goto data8/data16/done/error. > > Of course, otherwise we'd have a bug. The abort() ensures that this > remains the case in the future as well. > I see. Thanks!
Best regards, -Gonglei
