> -----Original Message----- > From: Paolo Bonzini [mailto:[email protected]] On Behalf Of Paolo > Bonzini > Sent: Tuesday, May 27, 2014 9:35 PM > To: Gonglei (Arei); [email protected] > Cc: [email protected]; chenliang (T); [email protected]; > Huangweidong (C); [email protected]; [email protected]; Luonengjun; > [email protected]; [email protected]; [email protected]; > [email protected]; [email protected]; [email protected]; > [email protected]; [email protected]; [email protected] > Subject: Re: [PATCH 3/8] json-parser: fix two coverity defects > > Il 27/05/2014 03:40, [email protected] ha scritto: > > t *ctxt, va_list *ap) > > } > > token = NULL; > > } else { > > - token = parser_context_pop_token(ctxt); > > - token = NULL; > > + (void)parser_context_pop_token(ctxt); > > } > > > > return QOBJECT(dict); > > @@ -542,8 +541,7 @@ static QObject *parse_array(JSONParserContext > *ctxt, va_list *ap) > > > > token = NULL; > > } else { > > - token = parser_context_pop_token(ctxt); > > - token = NULL; > > + (void)parser_context_pop_token(ctxt); > > } > > > > return QOBJECT(list); > > You used to have 2 dead stores, now you have 4. :) Please remove all > the token = NULL assignments. > OK, Thanks!
Best regards, -Gonglei
