On 04/29/2014 04:25 AM, Alex Bennée wrote:
>> +static void reloc_pc24(tcg_insn_unit *pc, tcg_insn_unit *target)
>> {
>> - *(uint32_t *)pc = (*(uint32_t *)pc & ~0x3fffffc)
>> - | reloc_pc24_val(pc, target);
>> + *pc = (*pc & ~0x3fffffc) | reloc_pc24_val(pc, target);
>> }
>
> Should 0x3fffffc be a #define'd mask? Can the PC ever actually be
> non-word aligned?
No, it can't be unaligned. The 0x3fffffc is really the field into
which the offset is being placed. I don't think a define is helpful
really, since this is the only place it's used.
r~
