Hiya, Cool. Definitely more compact and less intrusive, and definitely should catch more issues than the original page->flags check. The only possible cost is maintenance and debugging (implicit state and all that)... so... How about adding a comment around the "if (have_tb_lock)" to explain how we can get there?
Acked-by: Andrei Warkentin <[email protected]> 2014-04-03 12:53 GMT-04:00 Peter Maydell <[email protected]>: > On 3 April 2014 17:51, Richard Henderson <[email protected]> wrote: >> On 04/03/2014 09:45 AM, Peter Maydell wrote: >>> + if (have_tb_lock) { >>> + spin_unlock(&tcg_ctx.tb_ctx.tb_lock); >>> + } >> >> It ought not matter, since we ought to exit the loop on the >> next round, but i have a strong preference for resetting >> have_tb_lock here. > > Absolutely -- dumb oversight on my part. > > thanks > -- PMM -- A
