Il 30/10/2013 13:29, Kevin Wolf ha scritto: >> > bdrv_acct_start(s->bs, &s->acct, size, BDRV_ACCT_READ); >> > s->status = READY_STAT | SEEK_STAT | DRQ_STAT; >> > - s->bus->dma->ops->start_dma(s->bus->dma, s, >> > - ide_atapi_cmd_read_dma_cb); >> > + ide_start_dma(s, ide_atapi_cmd_read_dma_cb); > I was wondering whether the s->status update should be moved into > ide_start_dma(). Then I noticed that the value is different here, > because it's lacking BSY. Probably an inconsistency that wouldn't hurt > to get rid of? (The spec says that during a DMA operation BSY or DRQ or > both must be set.)
You are probably right. BTW, the last patch in the series does that for another assignment that is common to all ide_start_dma call sites. Paolo
