Am 28.10.2013 um 17:43 hat Paolo Bonzini geschrieben:
> Make it optional and prepare for the next patches.
>
> Signed-off-by: Paolo Bonzini <pbonz...@redhat.com>
> ---
> hw/ide/atapi.c | 6 ++----
> hw/ide/core.c | 15 ++++++++-------
> hw/ide/internal.h | 1 +
> 3 files changed, 11 insertions(+), 11 deletions(-)
>
> diff --git a/hw/ide/atapi.c b/hw/ide/atapi.c
> index 05e60b1..a7688bf 100644
> --- a/hw/ide/atapi.c
> +++ b/hw/ide/atapi.c
> @@ -255,8 +255,7 @@ static void ide_atapi_cmd_reply(IDEState *s, int size,
> int max_size)
> if (s->atapi_dma) {
> bdrv_acct_start(s->bs, &s->acct, size, BDRV_ACCT_READ);
> s->status = READY_STAT | SEEK_STAT | DRQ_STAT;
> - s->bus->dma->ops->start_dma(s->bus->dma, s,
> - ide_atapi_cmd_read_dma_cb);
> + ide_start_dma(s, ide_atapi_cmd_read_dma_cb);
I was wondering whether the s->status update should be moved into
ide_start_dma(). Then I noticed that the value is different here,
because it's lacking BSY. Probably an inconsistency that wouldn't hurt
to get rid of? (The spec says that during a DMA operation BSY or DRQ or
both must be set.)
Kevin
