On 21 February 2013 14:02, Anna Neiman <[email protected]> wrote: > +#if defined(TARGET_ARM) > + cpu_get_reg_var_func = cpu_get_reg_var_arm; > +#else > + cpu_get_reg_var_func = 0; > +#endif
No new for-each-target #ifdef ladders, please. Consider also whether you can abstract away some of the TARGET_LONG ifdefs. You need to look up what the C spec says about local variable values after longjmp() :-) Some of this patch is touching parts of QEMU which are critical and hard to understand, so you'll need to provide good patch commit messages to convince us that your changes are correct and safe. Strong agreement with other review comments about splitting the patch and that just exposing every target's cpu_env local variable is a really bad idea. thanks -- PMM
