Anna, Am 21.02.2013 15:29, schrieb Jan Kiszka: > <snip very long patch> > > I just hope the other 24027 patches won't come over us in the next > second. ;) > > Please split the patch, at least into > - prepare infrastructure for feature (that might also be several steps) > - add feature (or features, then also in several steps)
+1 Further please be aware that there are ongoing CPUState refactorings: - Adding target-independent fields to CPU_COMMON is undesired. Please add to include/qom/cpu.h CPUState whenever possible. - We are targetting to allow compiling multiple targets into one executable, so exposing static cpu_env variables per target is a "regression". Please rather move cpu_env to one central file (qom/cpu.c?) and let targets access it as extern (reverse direction). - Your patch will not apply to qemu.git, current_tb for instance was moved from CPU_COMMON to CPUState on Monday. Please always rebase before sending. I don't see a need to name fields in either CPU_COMMON or CPUState qemu_something. Identifiers starting with underscore are reserved in C99 and should not be used (translate-gdbagent.h guard). Please CC me on v2, part of this should go through my qom-cpu queue or at least be coordinated. Thanks, Andreas -- SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg
