On 2012-10-20 06:24, Aurelien Jarno wrote:
> Agreed. On the other hand, the few lines just above the one your quoted
> would be more complicated:
>
> + if (!(call_flags & TCG_CALL_NO_READ_GLOBALS)) {
> + /* globals should be synced to memory */
> + memset(mem_temps, 1, s->nb_globals);
> + }
>
> would have to be written:
>
> + if (!(call_flags & TCG_CALL_NO_READ_WRITE_GLOBALS) ||
> + (call_flags & TCG_CALL_WRITE_GLOBALS)) {
> + /* globals should be synced to memory */
> + memset(mem_temps, 1, s->nb_globals);
> + }
>
> Note sure it makes the things clearer, and definitely not shorter.
Ah, didn't think of that. Oh well.
r~
