On 10/09/2012 12:56 PM, Aurelien Jarno wrote:
> + if (!(call_flags & (TCG_CALL_NO_WRITE_GLOBALS |
> + TCG_CALL_NO_READ_GLOBALS))) {
Code like this would be shorter, and perhaps clearer, by
> +/* Helper does not read globals (either directly or through an exception). It
> + implies TCG_CALL_NO_WRITE_GLOBALS. */
> +#define TCG_CALL_NO_READ_GLOBALS 0x0010
> +/* Helper does not write globals */
> +#define TCG_CALL_NO_WRITE_GLOBALS 0x0020
having RG actually include WG, i.e.
#define TCG_CALL_NO_READ_GLOBALS 0x0030
That said,
Reviewed-by: Richard Henderson <[email protected]>
r~
