On 27/01/2026 17.15, [email protected] wrote:
From: Jared Rossi <[email protected]>

Remove the duplicate definitions from hw/s390x/ipl.h and pc-bios/s390-ccw/iplb.h
and add a shared definition.  The new definition is an enum to enforce default
handling in switches.

Signed-off-by: Jared Rossi <[email protected]>
---
  hw/s390x/ipl.h              |  5 -----
  include/hw/s390x/ipl/qipl.h | 10 ++++++++++
  pc-bios/s390-ccw/iplb.h     |  4 ----
  pc-bios/s390-ccw/main.c     |  9 +++++++--
  pc-bios/s390-ccw/virtio.h   |  1 +
  5 files changed, 18 insertions(+), 11 deletions(-)
...
@@ -198,7 +200,10 @@ static void boot_setup(void)
      }
if (have_iplb) {
+        vdev->ipl_type = iplb.pbt;
          menu_setup();
+    } else {
+        vdev->ipl_type = QEMU_DEFAULT_IPL;
      }

Could you maybe add a sentence about that new DEFAULT_IPL setting to the patch description? I assume this is some prep work for some of the following patches? In that case, please mention it. Otherwise this looks unnecessary when just looking at the context of this single patch.

 Thanks,
  Thomas


Reply via email to