Hi Shivansh, Sorry for late reply.
On Fri, Nov 21, 2025 at 08:34:48AM +0000, Shivansh Dhiman wrote: > Date: Fri, 21 Nov 2025 08:34:48 +0000 > From: Shivansh Dhiman <[email protected]> > Subject: [PATCH 1/5] i386: Implement CPUID 0x80000026 > X-Mailer: git-send-email 2.43.0 > > Implement CPUID leaf 0x80000026 (AMD Extended CPU Topology). It presents the > complete topology information to guests via a single CPUID with multiple > subleafs, each describing a specific hierarchy level, viz. core, complex, > die, socket. > > Note that complex/CCX level relates to "die" in QEMU, and die/CCD level is > not supported in QEMU yet. Hence, use CCX at CCD level until diegroups are > implemented. I'm trying to understand AMD's topology hierarchy by comparing it to the kernel's arch/x86/kernel/cpu/topology_ext.c file: static const unsigned int topo_domain_map_0b_1f[MAX_TYPE_1F] = { [SMT_TYPE] = TOPO_SMT_DOMAIN, [CORE_TYPE] = TOPO_CORE_DOMAIN, [MODULE_TYPE] = TOPO_MODULE_DOMAIN, [TILE_TYPE] = TOPO_TILE_DOMAIN, [DIE_TYPE] = TOPO_DIE_DOMAIN, [DIEGRP_TYPE] = TOPO_DIEGRP_DOMAIN, }; static const unsigned int topo_domain_map_80000026[MAX_TYPE_80000026] = { [SMT_TYPE] = TOPO_SMT_DOMAIN, [CORE_TYPE] = TOPO_CORE_DOMAIN, [AMD_CCD_TYPE] = TOPO_TILE_DOMAIN, [AMD_SOCKET_TYPE] = TOPO_DIE_DOMAIN, }; What particularly puzzles me is that "complex" isn't listed here, yet it should be positioned between "core" and CCD. Does this mean complex actually corresponds to kernel's module domain? Back to QEMU, now CCX is mapped as QEMU's die level, and AMD socket is mapped to socket level. Should we revisit QEMU's topology level mapping for AMD, to align with the above topology domain mapping? If we want to go further: supporting CCD configuration would be quite tricky. I feel that adding another new parameter between the smp.dies and smp.sockets would create significant confusion. > Signed-off-by: Shivansh Dhiman <[email protected]> > --- > target/i386/cpu.c | 76 +++++++++++++++++++++++++++++++++++++++++++ > target/i386/kvm/kvm.c | 17 ++++++++++ > 2 files changed, 93 insertions(+) > > diff --git a/target/i386/cpu.c b/target/i386/cpu.c > index 641777578637..b7827e448aa5 100644 > --- a/target/i386/cpu.c > +++ b/target/i386/cpu.c > @@ -495,6 +495,78 @@ static void encode_topo_cpuid1f(CPUX86State *env, > uint32_t count, > assert(!(*eax & ~0x1f)); > } > > +/* > + * CPUID_Fn80000026: Extended CPU Topology > + * > + * EAX Bits Description > + * 31:5 Reserved > + * 4:0 Number of bits to shift Extended APIC ID right to get a unique > + * topology ID of the current hierarchy level. > + * > + * EBX Bits Description > + * 31:16 Reserved > + * 15:0 Number of logical processors at the current hierarchy level. > + * > + * ECX Bits Description > + * 31:16 Reserved > + * 15:8 Level Type. Values: > + * Value Description > + * 0h Reserved > + * 1h Core > + * 2h Complex > + * 3h Die > + * 4h Socket > + * FFh-05h Reserved > + * 7:0 Input ECX > + * > + * EDX Bits Description > + * 31:0 Extended APIC ID of the logical processor > + */ I feel this long comment is not necessary, since people could check APM for details. Or this description could be included in commit message. > +static void encode_topo_cpuid80000026(CPUX86State *env, uint32_t count, > + X86CPUTopoInfo *topo_info, > + uint32_t *eax, uint32_t *ebx, > + uint32_t *ecx, uint32_t *edx) Regards, Zhao
