On Tue, 2 Dec 2025 00:13:06 +1000 Gavin Shan <[email protected]> wrote:
> Hi Mauro, > > On 12/1/25 10:17 PM, Mauro Carvalho Chehab wrote: > > On Thu, 27 Nov 2025 10:44:30 +1000 > > Gavin Shan <[email protected]> wrote: > > > >> This series is curved from that for memory error handling improvement > >> [1] based on the received comments, to improve the error object handling > >> in various aspects. > >> > >> [1] https://lists.nongnu.org/archive/html/qemu-arm/2025-11/msg00534.html > >> > >> Gavin Shan (5): > >> acpi/ghes: Automate data block cleanup in acpi_ghes_memory_errors() > >> acpi/ghes: Abort in acpi_ghes_memory_errors() if necessary > >> target/arm/kvm: Exit on error from acpi_ghes_memory_errors() > >> acpi/ghes: Bail early on error from get_ghes_source_offsets() > >> acpi/ghes: Use error_fatal in acpi_ghes_memory_errors() > > > > Patch series look ok on my eyes. > > > > Reviewed-by: Mauro Carvalho Chehab <[email protected]> > > > > Thanks. > > > - > > > > Btw, what setup are you using to test memory errors? It would be > > nice to have it documented somewhere, maybe at > > docs/specs/acpi_hest_ghes.rst. > > > > I don't think docs/specs/acpi_hest_ghes.rst is the right place for that > as it's for specifications. Perhaps not, but it would be nice to have it documented somewhere, either there or at QEMU wiki. > I'm sharing how this is tested here to make the thread complete. Thanks! > > - Both host and guest has 4KB page size > > - Start the guest by the following command lines > > /home/gavin/sandbox/qemu.main/build/qemu-system-aarch64 \ > -accel kvm -machine virt,gic-version=host,nvdimm=on,ras=on \ > -cpu host -smp maxcpus=8,cpus=8,sockets=2,clusters=2,cores=2,threads=1 \ > -m 4096M,slots=16,maxmem=128G \ > -object memory-backend-ram,id=mem0,size=4096M \ > -numa node,nodeid=0,cpus=0-7,memdev=mem0 \ > -L /home/gavin/sandbox/qemu.main/build/pc-bios \ > -monitor none -serial mon:stdio -nographic \ > -gdb tcp::6666 -qmp tcp:localhost:5555,server,wait=off \ > -bios /home/gavin/sandbox/qemu.main/build/pc-bios/edk2-aarch64-code.fd \ > -boot c \ > -device pcie-root-port,bus=pcie.0,chassis=1,id=pcie.1 \ > -device pcie-root-port,bus=pcie.0,chassis=2,id=pcie.2 \ > -device pcie-root-port,bus=pcie.0,chassis=3,id=pcie.3 \ > : \ > -device pcie-root-port,bus=pcie.0,chassis=16,id=pcie.16 \ > -drive file=/home/gavin/sandbox/images/disk.qcow2,if=none,id=drive0 \ > -device virtio-blk-pci,id=virtblk0,bus=pcie.1,drive=drive0,num-queues=4 \ > -netdev > tap,id=tap1,vhost=true,script=/etc/qemu-ifup,downscript=/etc/qemu-ifdown \ > -device virtio-net-pci,bus=pcie.8,netdev=tap1,mac=52:54:00:f1:26:b0 > > - Trigger 'victim -d' in the guest Hmm... from where I can get victim? Regards, Mauro
