Hi Markus,

On 11/27/25 6:14 PM, Markus Armbruster wrote:
Gavin Shan <[email protected]> writes:

Use error_fatal in acpi_ghes_memory_errors() so that the caller needn't
explicitly call exit(). The return value of acpi_ghes_memory_errors()
and ghes_record_cper_errors() is changed to 'bool' indicating an error
has been raised, to be compatible with what's documented in error.h.

Suggested-by: Igor Mammedov <[email protected]>
Suggested-by: Markus Armbruster <[email protected]>
Signed-off-by: Gavin Shan <[email protected]>
Reviewed-by: Jonathan Cameron <[email protected]>

Reviewed-by: Markus Armbruster <[email protected]>

I figure I would've split this for easier review, say 1. return bool,
2. convert acpi_ghes_memory_errors to Error.  Since you already got
review, it's probably not worthwhile now.  Next time :)


Nice point, thanks for your review. Lets try to do that next time :)

Thanks,
Gavin


Reply via email to