Alex Bennée <[email protected]> writes:
> We didn't make the device user creatable in the first place because we
> were worried users might get confused. Rename the device to make its
> nature as a test device even more explicit. While we are at it add a
> Kconfig variable so it can be skipped for those that want to thin out
> their build configuration even further.
>
> Acked-by: Stefano Garzarella <[email protected]>
> Reviewed-by: Manos Pitsidianakis <[email protected]>
> Reviewed-by: Stefan Hajnoczi <[email protected]>
> Signed-off-by: Alex Bennée <[email protected]>
> Message-ID: <[email protected]>
>
<snip>
> --- a/hw/virtio/vhost-user-device-pci.c
> +++ b/hw/virtio/vhost-user-test-device-pci.c
> @@ -18,13 +18,13 @@ struct VHostUserDevicePCI {
> VHostUserBase vub;
> };
>
> -#define TYPE_VHOST_USER_DEVICE_PCI "vhost-user-device-pci-base"
> +#define TYPE_VHOST_USER_TEST_DEVICE_PCI "vhost-user-test-device-pci"
oops dropping the -base here broke:
>
> static const VirtioPCIDeviceTypeInfo vhost_user_device_pci_info = {
> - .base_name = TYPE_VHOST_USER_DEVICE_PCI,
> - .non_transitional_name = "vhost-user-device-pci",
> + .base_name = TYPE_VHOST_USER_TEST_DEVICE_PCI,
> + .non_transitional_name = "vhost-user-test-device-pci",
> .instance_size = sizeof(VHostUserDevicePCI),
> .instance_init = vhost_user_device_pci_instance_init,
> .class_init = vhost_user_device_pci_class_init,
<snip>
the checking here. So I have sent v2:
Subject: [PATCH v2] hw/virtio: rename vhost-user-device and make user
creatable
Date: Mon, 1 Sep 2025 11:59:48 +0100
Message-ID: <[email protected]>
--
Alex Bennée
Virtualisation Tech Lead @ Linaro
