> -----Original Message-----
> From: Li Zhijian <[email protected]>
> Sent: Thursday, May 9, 2024 11:31 AM
> To: Peter Xu <[email protected]>; Fabiano Rosas <[email protected]>
> Cc: Zhang, Hailiang <[email protected]>; qemu-
> [email protected]; Zhang, Chen <[email protected]>; Li Zhijian
> <[email protected]>; Michael Tokarev <[email protected]>
> Subject: [PATCH 3/3] migration/colo: Tidy up bql_unlock() around
> bdrv_activate_all()
>
> Make the code more tight.
>
> Cc: Michael Tokarev <[email protected]>
> Signed-off-by: Li Zhijian <[email protected]>
Reviewed-by: Zhang Chen <[email protected]>
Thanks
Chen
> ---
> This change/comment suggested by "Michael Tokarev <[email protected]>"
> came a bit late at that time, let's update it together in these minor set this
> time.
> ---
> migration/colo.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/migration/colo.c b/migration/colo.c index 991806c06a..1b6d9da1c8
> 100644
> --- a/migration/colo.c
> +++ b/migration/colo.c
> @@ -838,12 +838,11 @@ static void *colo_process_incoming_thread(void
> *opaque)
> /* Make sure all file formats throw away their mutable metadata */
> bql_lock();
> bdrv_activate_all(&local_err);
> + bql_unlock();
> if (local_err) {
> - bql_unlock();
> error_report_err(local_err);
> return NULL;
> }
> - bql_unlock();
>
> failover_init_state();
>
> --
> 2.31.1
